"The configuration was reverted to its source."

I think this message should include the config name also.

"The configuration %item has been reverted to its source."

CommentFileSizeAuthor
#7 After patch.png20.56 KBChris Matthews
#7 Before patch.png14.77 KBChris Matthews
#6 3018893-6-messages.patch3.42 KBPasqualle
#2 3018893-2-messages.patch2.2 KBPasqualle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pasqualle created an issue. See original summary.

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle as a volunteer commented
Status: Active » Needs review
FileSize
3018893-2-messages.patch2.2 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

This looks quite reasonable to me, thanks!

I'll have to see if %item is the right thing to do in t() these days... I can never remember what the codes mean (% vs @ vs ! or whatever) in t() messages.

And we'll need to see if the tests pass. There may be a test that looked for the previous message, that will now fail, so some tests may need to be updated.

Status: Needs review » Needs work

The last submitted patch, 2: 3018893-2-messages.patch, failed testing. View results

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle as a volunteer commented

placeholderFormat

short explanation:
@ = plain text
% = plain text + em
: = html (same as ! in D7)

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle as a volunteer commented
Status: Needs work » Needs review
FileSize
3018893-6-messages.patch3.42 KB
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Status: Needs review » Reviewed & tested by the community
FileSize
Before patch.png14.77 KB
After patch.png20.56 KB

The patch in #6 applied cleanly on 8.x-1.x-dev and does the trick for me.

Before Patch

After patch

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, test update, and review! I agree, this looks good. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.