Problem/Motivation

The Local Tasks and Many of the Links Throughout the Layout Builder UI Use Title Case

Proposed resolution

They should not.

Remaining tasks

Fix it

User interface changes

Yes

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#15 3018073-titlecase-15.patch46.44 KBtim.plunkett
#12 3018073-titlecase-12.patch44.39 KBmark_fullmer
#12 3018073-titlecase-12.interdiff.txt1.46 KBmark_fullmer
#9 diff_6-9.txt9.27 KBkostyashupenko
#9 3018073-titlecase-9.patch43.09 KBkostyashupenko
#6 3018073-titlecase-6-interdiff.txt983 bytestim.plunkett
#6 3018073-titlecase-6.patch42.16 KBtim.plunkett
#4 3018073-titlecase-4.patch41.2 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented

Note that Mink is case-sensitive, so all of the clickLink() calls in the tests will also have to be updated.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Active » Needs review
FileSize
3018073-titlecase-4.patch41.2 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3018073-titlecase-4.patch, failed testing. View results

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Needs work » Needs review
FileSize
3018073-titlecase-6.patch42.16 KB
3018073-titlecase-6-interdiff.txt983 bytes

Forgot about CM

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Needs review » Reviewed & tested by the community
johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Woops. I was too fast on the status, I actually meant to set this to NW.

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3018073-titlecase-9.patch43.09 KB
diff_6-9.txt9.27 KB

Rerolled & patch updated

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented

Using ['"][A-Z][a-z]+ [A-Z][a-z]+['"] I found some occurrences left:

MoveBlockForm.php:152

    $form['components_wrapper']['components'] = [
      '#type' => 'table',
      '#header' => [
        $this->t('Block Label'),
        $this->t('Weight'),
      ],

Element/LayoutBuilder.php:362

      // The section label is added to sections without a "Configure Section"
      // link, and is only visible when the move block dialog is open.

Other than that, I think this looks good.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Issue tags: +sprint

Tagging

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
FileSize
3018073-titlecase-12.interdiff.txt1.46 KB
3018073-titlecase-12.patch44.39 KB

Attached is a patch and interdiff including the 2 changes identified in #10.

JacobSanford’s picture

JacobSanford
Primary language English
Location Fredericton 🇨🇦
CreditAttribution: JacobSanford as a volunteer commented
Assigned: Unassigned » JacobSanford
Issue tags: +Seattle2019

Working on now at Drupalcon

JacobSanford’s picture

JacobSanford
Primary language English
Location Fredericton 🇨🇦
CreditAttribution: JacobSanford as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks for the contributions. I have reviewed the patch and the only title case usage inside layout builder that remains is where appropriate/ignored:

Setting to RTBC

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Assigned: JacobSanford » Unassigned
FileSize
3018073-titlecase-15.patch46.44 KB

Reroll.

  • xjm committed 82bba27 on 8.8.x 
    Issue #3018073 by tim.plunkett, kostyashupenko, mark_fullmer, johndevman...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Fixed

I Reviewed This With git diff --color-words and Confirmed Each Change Is Correct. There Are Four Labels Fixed:

Add Block
Add Section
Block Label
Configure Section

I Did a Case-Sensitive Grep for All Three Four and Confirmed There Are No Remaining Title-Case Instances.

Committed and Pushed to 8.8.x. Thanks!

I Did Not Backport This to 8.7.x Because Strings Are Frozen During RC.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.