Problem/Motivation

Redirect responses are currently not supported in Tome, but should be.

Proposed resolution

Create an API for handling redirects, that can be extended to generate an .htaccess file or Netlify _redirects file before falling back to an HTML redirect (with <meta http-equiv="refresh" content="0; url=..." />).

Remaining tasks

Write a patch.

User interface changes

None.

API changes

TBD.

Data model changes

None.

Release notes snippet

TBD.

CommentFileSizeAuthor
#10 interdiff-3017423-9-10.txt972 bytessamuel.mortenson
#10 3017423-10.patch13.13 KBsamuel.mortenson
#9 interdiff-3017423-8-9.txt1.02 KBsamuel.mortenson
#9 3017423-9.patch13.42 KBsamuel.mortenson
#8 interdiff-3017423-6-8.txt3.1 KBsamuel.mortenson
#8 3017423-8.patch14.44 KBsamuel.mortenson
#6 interdiff-3017423-4-6.txt659 bytessamuel.mortenson
#6 3017423-6.patch15.82 KBsamuel.mortenson
#4 interdiff-3017423-3-4.txt4.15 KBsamuel.mortenson
#4 3017423-4.patch16.03 KBsamuel.mortenson
#3 interdiff-3017423-2-3.txt6.39 KBsamuel.mortenson
#3 3017423-3.patch12.68 KBsamuel.mortenson
#2 3017423-2.patch11.15 KBsamuel.mortenson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samuel.mortenson created an issue. See original summary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
FileSize
3017423-2.patch11.15 KB

Here's a start to this, should have time before beta 2 to add tests. Still need to add some kind of event API for reacting to responses.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
FileSize
3017423-3.patch12.68 KB
interdiff-3017423-2-3.txt6.39 KB

Test coverage added, need to add the API.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Active » Needs review
FileSize
3017423-4.patch16.03 KB
interdiff-3017423-3-4.txt4.15 KB

This event should be enough to generate a redirects file.

Status: Needs review » Needs work

The last submitted patch, 4: 3017423-4.patch, failed testing. View results

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs work » Needs review
FileSize
3017423-6.patch15.82 KB
interdiff-3017423-4-6.txt659 bytes

Huh, didn't know this annotation was possible.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented

This looks good, but I'm wondering if instead of a new event, we could just flag Tome requests in a way that typical Response subscribers could pick up on - No new API necessary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
FileSize
3017423-8.patch14.44 KB
interdiff-3017423-6-8.txt3.1 KB

This feels way better.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
FileSize
3017423-9.patch13.42 KB
interdiff-3017423-8-9.txt1.02 KB
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
FileSize
3017423-10.patch13.13 KB
interdiff-3017423-9-10.txt972 bytes

  • samuel.mortenson authored f1a4b16 on 8.x-1.x 
    Issue #3017423 by samuel.mortenson: Create an API for handling redirects
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer and at PreviousNext commented

If anyone is trawling through Tome code and is wondering how/where the redirect is added, it can be found in Symfony as a form of a fallback to Location headers in \Symfony\Component\HttpFoundation\RedirectResponse.