Problem/Motivation
#2659940: Extension System, Part III: ThemeExtensionList and ThemeEngineExtensionList introduced a weight public property on Themes' extension objects. There was no discussion and we still have comments like
// The value is not used; the weight is ignored for themes currently.
and runtime code like
// Set the actual theme weights.
$theme_list = array_map(function ($theme) use ($theme_data) {
return $theme_data[$theme]->sort;
}, $theme_list);
// Sort the theme list by their weights (reverse).
arsort($theme_list);
$theme_list = array_keys($theme_list);
Proposed resolution
Remove the weight property because it is confusing and unnecessary.
This need to be done before 8.7.0 otherwise it is anAPI change.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
N/a
Comment | File | Size | Author |
---|---|---|---|
#4 | 3016968-4.patch | 1.24 KB | alexpott |
#4 | 2-4-interdiff.txt | 588 bytes | alexpott |
#2 | 3016968-2.patch | 677 bytes | alexpott |
Comments
Comment #2
alexpottComment #4
alexpottComment #5
phenaproximaNice clean-up; looks good to me. Adding tags and queueing the tests on additional backends. RTBC once everything is green.
Comment #6
catchCommitted 9effdc6 and pushed to 8.7.x. Thanks!