Invalid address saved

I changed the issue title to something more accurate. The addresses are not duplicates. They are similar, with one version lacking a required field.

Fixed. Thanks for catching this as it led me to catch a few more things.

Could you please get the latest code from CVS (or wait until the dev build is updated) and let me know if I've fixed your problem without introducing any new ones?

Thanks!

I used the wonderful TortoiseCVS program and WinMerge to look at that version 1.1.2.3 of uc_addresses.module and the previous version and help me remember what I did. I believe the fix for the problem you reported was a one line fix. From:

function uc_addresses_order($op, &$arg1, $arg2)
{
  if ($op == 'save') {

to

function uc_addresses_order($op, &$arg1, $arg2)
{
  if ($op == 'update' && $arg1->order_status == 'in_checkout' && $arg2 == 'payment_received') {

The idea is I now check for the addresses only when a payment is received. This is the best clue I have that the order has been placed and finalized. Before, I would try to save the addresses every time the order was saved, which occurred when you moved from the checkout page to the review order page. If you moved back to the checkout page, I would save the addresses again, correct or incorrect.

I would recommend upgrading to the 2.0-rc1 release as it has a lot of other important bug fixes.

I have to re-check, but I believe that there is no special signal that I would get at that point. The order is actually saved when you go from the checkout page to the review page. If the payment is COD, I'm not sure I will get a signal when the user submits the COD order. I'll have to try it to be sure.

I don't think your proposal will work.

I thought about the database query and I think that it would be possible to write one that does what you are asking. But you could get back more than one match. Which one would get updated?

The reason you could get back more than one match is that when a user manually adds a new address (through My Account), I am not going to second-guess them and turn the add into an update. The algorithm you propose would, at most, be applied to automatic address saving during checkout.

Also, consider this: I go to checkout and enter the wrong street address. Then I click on Review Order. I see the wrong address and go back to correct it. I click on Review Order again. Now there are two addresses added, one of which is incorrect and I still have the bug you filed.

Let me know if I my reasoning makes sense to you.

Ok, after some study and testing with COD and credit card orders, I came up with this:

function uc_addresses_order($op, &$arg1, $arg2)
{
  if ($op == 'submit' && $arg1->order_status == 'in_checkout') {

I'm not sure how I missed the 'submit' state before, but together with 'in_checkout', it seems to capture the data after pressing the Submit button to finalize the checkout order (seems so obvious now).

The code is checked in to CVS and should show up in the dev build in a day or so.

Thanks for thinking about this. If you see any other problems, let me know!