Problem/Motivation

Drupal and DrupalPractice ask for changes in src/Plugin/migrate/process/GoogleAnalyticsVisibilityRoles.php

Proposed resolution

Apply changes askeds in src/Plugin/migrate/process/GoogleAnalyticsVisibilityRoles.php

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 google_analitycs-coding_standards_in_GoogleAnalyticsVisibilityRoles-3011993.patch604 bytesthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
google_analitycs-coding_standards_in_GoogleAnalyticsVisibilityRoles-3011993.patch604 bytes

Hi Follow the patch

Akshay kashyap’s picture

Akshay kashyap CreditAttribution: Akshay kashyap as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented

@Thalles Thanks for the patch. i have applied your patch. it working fine for me and solve the drupal coding standard issue.

Akshay kashyap’s picture

Akshay kashyap CreditAttribution: Akshay kashyap as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Assigned: thalles » Unassigned

  • hass committed 8f107e3 on 8.x-3.x authored by thalles 
    Issue #3011993 by thalles: Coding standards in...

  • hass committed 6153d65 on 8.x-2.x authored by thalles 
    Issue #3011993 by thalles: Coding standards in...
hass’s picture

hass CreditAttribution: hass commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.