Problem/Motivation

EntityTypeManagerInterface uses the $entity_type variable name when it refers to the entity type ID.

Proposed resolution

Rename all $entity_type variable names to $entity_type_id, which is the standard naming pattern when referring to the name of an entity type.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#2 3010805.patch13.12 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
3010805.patch13.12 KB

This should do it.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +DX (Developer Experience)

Useful clean-up!

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Factorial GmbH commented

Makes sense to me. +1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed c2226f7 and pushed to 8.7.x. Thanks!

  • alexpott committed c2226f7 on 8.7.x 
    Issue #3010805 by amateescu: Fix misleading variable names in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.