Migration entity count not tested in MigrateUpgrade Tests

The test gets all the entities on the destination site and then checks that the count matches the count in the large array of expected counts. When there are more entity types in the expected array than on the actual site the count for those 'extra' entity types are simply ignored. When there are less entity types in the expected array than on the actual site the count for the 'missing' entity types defaults to zero and is tested. In both cases the list of expected entity types may not match what is actually tested. And I think they should.

The list of expected entity counts should be a accurate list of the entity types being tested.

To help make that happen I have added a test that compares the expected entity types with the actual entity types. And that test failed because contact_message was not in the expected list. Adding 'contact_message => 0' to the list and the test (MigrateUpgrade6Test) passed. The same line is added to the other tests but haven't run those tests locally.

The existing test is changed too, I removed the setting of the entity count to 0. That means that the expected count array now must list all the entities tested even if the count is 0.

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/MigrateUpgrade6NoMultilingualTest.php
@@ -58,6 +58,7 @@ protected function getEntityCounts() {
+      'contact_message' => 0,

@@ -66,7 +67,6 @@ protected function getEntityCounts() {
-      'migration' => 105,

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/ .php
@@ -61,6 +61,7 @@ protected function getEntityCounts() {
+      'contact_message' => 0,

@@ -68,7 +69,6 @@ protected function getEntityCounts() {
-      'migration' => 73,

Remove changes to these to two files.

The fact that the failing test didn't have more failures has been bothering me. So, did some checking and these two tests aren't running the full migration (although with the entity count lists it looks like they do). They simply test that the migration does not run unless migrate_drupal_multilingual is enabled which, as I recall, was the intention at the time.

Tagging novice to remove the changes to MigrateUpgrade6NoMultilingualTest and MigrateUpgrade7NoMultilingualTest.

Removed items as per #4