Problem/Motivation

When showing the summary, we can get text that can be only be tags with no context. If we have useful information, we might lose it if we do not display it.

Proposed resolution

If there is if the result of strip_tags() is empty, we'd fall back to a escaped version of the HTML tags, so it should something like "

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 paragraphs_3008364_11.patch2.61 KBmiro_dietiker
#10 interdiff-3008364-7-10.txt656 bytesjohnchque
#10 show_raw_summary-3008364-10.patch2.42 KBjohnchque
#7 interdiff-3008364-4-7.txt426 bytesjohnchque
#7 show_raw_summary-3008364-7.patch2.22 KBjohnchque
#4 interdiff-3008364-2-4.txt1.58 KBjohnchque
#4 show_raw_summary-3008364-4.patch2.22 KBjohnchque
#2 show_raw_summary-3008364-2.patch538 bytesjohnchque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Active » Needs review
FileSize
show_raw_summary-3008364-2.patch538 bytes

This should work, working on tests now. :)

Status: Needs review » Needs work

The last submitted patch, 2: show_raw_summary-3008364-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
show_raw_summary-3008364-4.patch2.22 KB
interdiff-3008364-2-4.txt1.58 KB

Ok, adding tests, not sure if HEAD is failing. Seems demo is used on some tests. We should remove that.

Status: Needs review » Needs work

The last submitted patch, 4: show_raw_summary-3008364-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Use methods like htmlspecialchars, not selfcoded replaces.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
show_raw_summary-3008364-7.patch2.22 KB
interdiff-3008364-4-7.txt426 bytes

That's true. Thanks.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented

Fails should be fixed in #3008584: Remove demo from tests :)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/src/Entity/Paragraph.php
@@ -503,7 +503,10 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
-    return strip_tags($collapsed_summary_text);

Sorry, i think this should go into the getTextSummary() method and the raw text also need to be truncated like usual for text fields.

Currently there wouldn't be any summary from such a text field as soon as a behavior setting is applied, making the summary as unclear as before. It's really a fallback for an empty text field.

We will work on displaying behavior summaries differently soon and keep this separated from the text summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
show_raw_summary-3008364-10.patch2.42 KB
interdiff-3008364-7-10.txt656 bytes

Right, updating. :)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
FileSize
paragraphs_3008364_11.patch2.61 KB

Did some rewrite as i don't want to drop the parent strip_tags to protect from bad content of other summary components like labels...

Ready?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Fixed

Awesome, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.