Split from #2982149: Routing: Convert system functional tests to phpunit into bite size chunks.

Scope:
./Render/HtmlResponseAttachmentsTest.php
./Render/UrlBubbleableMetadataBubblingTest.php

CommentFileSizeAuthor
#2 3007371-2.patch4.2 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Active » Needs review
FileSize
3007371-2.patch4.2 KB

here we go.

headers work a little differently, so thats what most of these changes are about

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • larowlan committed 802d1e4 on 8.7.x 
    Issue #3007371 by Lendude: System: Convert remaining Render functional...

  • larowlan committed ef4b40f on 8.6.x 
    Issue #3007371 by Lendude: System: Convert remaining Render functional...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented
Version: 8.7.x-dev » 8.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 802d1e4 and pushed to 8.7.x. Thanks!

Cherry-picked to 8.6.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.