ViewsExecutable type hint for $exposed_widgets is a string.
However... down at around line 1238 $this->exposed_widgets = $exposed_form->renderExposedForm() which sets it to a render array (or in some cases, an empty array).

CommentFileSizeAuthor
#12 3006812-viewexecutable-exposed-widgets-12.patch574 bytesAnkit.Gupta
#2 3006812-viewexecutable-exposed-widgets-2.patch574 bytesNickDickinsonWilde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NickWilde created an issue. See original summary.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde as a volunteer and at Taoti Creative commented
Assigned: NickDickinsonWilde » Unassigned
Status: Active » Needs review
FileSize
3006812-viewexecutable-exposed-widgets-2.patch574 bytes

Patch. I don't believe this needs a test.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pavlosdan’s picture

pavlosdan CreditAttribution: pavlosdan as a volunteer and at Acquia commented
Status: Needs review » Reviewed & tested by the community

Was wondering about this given the documentation says this should be a string.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Reviewed & tested by the community » Needs work

Sorry, but let's get this testing on Drupal 9.5 or 10 instead of an unsupported version of Drupal.

Ankit.Gupta’s picture

Ankit.Gupta CreditAttribution: Ankit.Gupta at Dotsquares Ltd. commented
Version: 9.5.x-dev » 10.1.x-dev
Status: Needs work » Needs review
FileSize
3006812-viewexecutable-exposed-widgets-12.patch574 bytes

Reroll the patch #2 with Drupal 10.1.x

daffie’s picture

daffie CreditAttribution: daffie at Finalist commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.
Nice little docblock improvement!
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 243783522d to 10.1.x and ab0ad0263a to 10.0.x and b16cfee784 to 9.5.x and e06fa31dc2 to 9.4.x. Thanks!

Backported to 9.4.x as docs bug fix.

  • alexpott committed 2437835 on 10.1.x 
    Issue #3006812 by NickDickinsonWilde, Ankit.Gupta: ViewsExecutable->...

  • alexpott committed ab0ad02 on 10.0.x 
    Issue #3006812 by NickDickinsonWilde, Ankit.Gupta: ViewsExecutable->...

  • alexpott committed b16cfee on 9.5.x 
    Issue #3006812 by NickDickinsonWilde, Ankit.Gupta: ViewsExecutable->...

  • alexpott committed e06fa31 on 9.4.x 
    Issue #3006812 by NickDickinsonWilde, Ankit.Gupta: ViewsExecutable->...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.