The last remaining WebTestBase test of the Views module and the last test extending the deprecated \Drupal\field\Tests\Views\FieldTestBase.

So just a one test here in scope.

CommentFileSizeAuthor
#2 3004968-2.patch925 bytesLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Active » Needs review
FileSize
3004968-2.patch925 bytes

Just a 1-1 conversion, straightforward...

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Reviewed & tested by the community

Simple conversion, test still pass. Great work @Lendude!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3004968-2.patch, failed testing. View results

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Needs work » Reviewed & tested by the community

Unrelated fail

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3004968-2.patch, failed testing. View results

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Dx Experts commented
Status: Needs work » Reviewed & tested by the community

09:52:58 [Example Test] Test Suite
09:52:58 =============================
09:52:58
09:52:58 Running: Test page
09:52:58
09:52:58 Error retrieving a new session from the selenium server

unrelated failure in nightwatch test

  • larowlan committed 6e4b0af on 8.7.x 
    Issue #3004968 by Lendude: Convert FieldApiDataTest to BrowserTestBase
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented
Version: 8.7.x-dev » 8.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 6e4b0af and pushed to 8.7.x. Thanks!

Cherry-picked to 8.6.x

  • larowlan committed f364b90 on 8.6.x 
    Issue #3004968 by Lendude: Convert FieldApiDataTest to BrowserTestBase...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.