The documentation for skip_on_value plugins seems to be copied from skip_on_empty plugin in some place (method configuration key) which is misleading. And the first example seems to be inconsistent regarding the actual example given and the text explaining this example.

Proposing to fix it like this ...

CommentFileSizeAuthor
#2 documentation_for_skip_on_value-3004258-002.patch1.4 KBstefan.korn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.korn created an issue. See original summary.

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented
FileSize
documentation_for_skip_on_value-3004258-002.patch1.4 KB
stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
CreditAttribution: stefan.korn at Stefan Korn - Webentwicklung commented
Assigned: stefan.korn » Unassigned
Status: Active » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

Looking good. Nice docs improvements.

  • heddn committed 2dbfdd4 on 8.x-4.x authored by stefan.korn 
    Issue #3004258 by stefan.korn, heddn: Documentation for skip_on_value
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contributions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.