Problem/Motivation

setDatabaseDumpFiles is called twice in \Drupal\FunctionalTests\Update\UpdatePathTestBase meaning if you have methods that build upon each other like so:

/**
   * {@inheritdoc}
   */
  protected function setDatabaseDumpFiles() {
    parent::setDatabaseDumpFiles();
    $this->databaseDumpFiles[] = __DIR__ . '/../../fixtures/site-schema-fresh-install-expanded-test-content.php';
  }

You will get a broken failing test.

Proposed resolution

Call the method once.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3003401-7.patch2.18 KBSam152
#2 3003401-2.patch2.06 KBSam152
#2 3003401-2-TEST-ONLY.patch1.38 KBSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Needs review
FileSize
3003401-2-TEST-ONLY.patch1.38 KB
3003401-2.patch2.06 KB

The last submitted patch, 2: 3003401-2-TEST-ONLY.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
CreditAttribution: pingwin4eg as a volunteer and at Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Really simple. Could be even backported to 8.8.x. I'm marking it RTBC.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Reviewed & tested by the community » Needs review
FileSize
3003401-7.patch2.18 KB

Reroll.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed daab6ad7c8 to 9.0.x and bdce2114ab to 8.9.x. Thanks!

8.8.x is frozen so we can't backport there yet.

  • alexpott committed daab6ad on 9.0.x 
    Issue #3003401 by Sam152: UpdatePathTestBase calls setDatabaseDumpFiles...

  • alexpott committed bdce211 on 8.9.x 
    Issue #3003401 by Sam152: UpdatePathTestBase calls setDatabaseDumpFiles...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Patch (to be ported) » Fixed

Backported this test only fix to 8.8.x

  • alexpott committed 22a5cca on 8.8.x 
    Issue #3003401 by Sam152: UpdatePathTestBase calls setDatabaseDumpFiles...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.