forum.index_storage:
  class: Drupal\forum\ForumIndexStorage
  arguments: ['@database', '@forum_manager']
  tags:
    - { name: backend_overridable }

ForumIndexStorage constructor only accepts database service.

CommentFileSizeAuthor
#3 forum_manager_3003111-1.patch494 bytesdhirendra.mishra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Assigned: Unassigned » dhirendra.mishra
Status: Active » Needs work
dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
forum_manager_3003111-1.patch494 bytes

Hey..Please find the below patch for the same.Kindly review and test my patch.

googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented
Status: Needs review » Reviewed & tested by the community

Some small house keeping. Let’s get this committed.

dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Assigned: dhirendra.mishra » Unassigned
dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented

is there anything else need to be done!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: forum_manager_3003111-1.patch, failed testing. View results

msankhala’s picture

msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commented
Status: Needs work » Needs review

Looks like a chatbot hickup. Lets put it in Need review again to run test bot. Or this issue is introduced in #2919795: Add visual hints that Layout Builder work is in tempstore and will not be lost, or take effect until saved Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest class is introduced in that issue.

msankhala’s picture

msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commented

Another issue which caused fail of test bot has been reverted https://www.drupal.org/project/drupal/issues/2919795#comment-12801338

Status: Needs review » Needs work

The last submitted patch, 3: forum_manager_3003111-1.patch, failed testing. View results

dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 0448071 and pushed to 8.7.x. Thanks!

  • catch committed 0448071 on 8.7.x 
    Issue #3003111 by dhirendra.mishra, Chi: forum.index_storage service...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.