book.export:
  class: Drupal\book\BookExport
  arguments: ['@entity.manager', '@book.manager', '@renderer']

Here is the constructor signature.
https://github.com/drupal/core/blob/8.6.1/modules/book/src/BookExport.ph...

CommentFileSizeAuthor
#4 book_export_service_3003106-4.patch537 bytesdhirendra.mishra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

Chi’s picture

Chi CreditAttribution: Chi commented
Title: book.export service declares does not need renderer » book.export service does not need renderer
dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Assigned: Unassigned » dhirendra.mishra
Status: Active » Needs work
dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
FileSize
book_export_service_3003106-4.patch537 bytes

Kindly find the patch for same.Please review and test my patch.Thanks

googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented
Status: Needs review » Reviewed & tested by the community

This was a good find, look good and all is green. RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: book_export_service_3003106-4.patch, failed testing. View results

dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra at Srijan | A Material+ Company commented
Status: Needs work » Needs review
Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Reviewed & tested by the community

Tests a green again.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 3c41d0c and pushed to 8.7.x. Thanks!

  • catch committed 3c41d0c on 8.7.x 
    Issue #3003106 by dhirendra.mishra, Chi: book.export service does not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.