I was noticing that the menu_link_content entries were getting a yearly changefreq because of their lastmod calculation. I don't think menu links should have any lastmod, as it's the link url what's important and if at all, it should respect default/specific configurations and not alter it on its own.

CommentFileSizeAuthor
#2 3002843-n2.patch713 byteshanoii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hanoii created an issue. See original summary.

hanoii’s picture

Status: Active » Needs review
FileSize
713 bytes

Attached is a patch for this.

renatog’s picture

Status: Needs review » Reviewed & tested by the community

Really works good and makes sense

  • RenatoG committed ec1a972 on 8.x-1.x authored by hanoii
    Issue #3002843 by hanoii, RenatoG: Do not use lastmod on menu links
    
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Dave Reid’s picture

Status: Closed (fixed) » Needs work

Does this result in a regression for other entity types however? Looks like we might be missing test coverage then.

Dave Reid’s picture

It definitely looks like our test coverage is lacking 'lastmod' coverage for entity types like nodes. Confirmed this would be a regression so I'm going to revert this commit for now until we can figure out a better way (and also add test coverage).

  • Dave Reid committed cfd3895 on 8.x-1.x
    Revert "Issue #3002843 by hanoii, RenatoG: Do not use lastmod on menu...