toolbar.menu_tree:
  class: Drupal\toolbar\Menu\ToolbarMenuLinkTree
  arguments: ['@menu.tree_storage', '@plugin.manager.menu.link', '@router.route_provider', '@menu.active_trail', '@controller_resolver', '@cache.menu', '@current_route_match']

@cache.menu and @current_route_match seems unused.

CommentFileSizeAuthor
#2 3002741-2.patch697 byteshardikpandya
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

hardikpandya’s picture

hardikpandya CreditAttribution: hardikpandya at Trigyn Technologies Ltd commented
Status: Active » Needs review
FileSize
3002741-2.patch697 bytes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Needs review » Reviewed & tested by the community

Yup, great catch!

Looks like this was missed in #2479363: Cache MenuActiveTrail::getActiveIds() for *all* menus per route match: 1 cache get instead of N DB queries, saves 1 ms/response.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Related issues: +#2479363: Cache MenuActiveTrail::getActiveIds() for *all* menus per route match: 1 cache get instead of N DB queries, saves 1 ms/response

  • catch committed d078c92 on 8.7.x 
    Issue #3002741 by hardikpandya, tstoeckler, Chi: toolbar.menu_tree...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d078c92 and pushed to 8.7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.