Problem/Motivation

There is no "label" in the entity_keys on the Organization entity. This causes issues when using the migrate module to lookup or generate an Organization.

CommentFileSizeAuthor
#10 crm_core-3002667-10.patch1.29 KBRoSk0
#2 crm_core_contact-3002667-2.patch558 bytesJuterpillar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Juterpillar created an issue. See original summary.

Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
FileSize
crm_core_contact-3002667-2.patch558 bytes

Patch attached.

Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
Assigned: Juterpillar » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: crm_core_contact-3002667-2.patch, failed testing. View results

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl as a volunteer commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: crm_core_contact-3002667-2.patch, failed testing. View results

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl as a volunteer commented

Thanks for the patch, I'm not sure if we should be adding this as an entity_key when a complex field like name is behind it.

Can you please share your migrate_lookup mapping for easier testing? I'm wondering if maybe #2961428: migration_lookup process plugin can't use multiple or specific source keys to use for lookup is also relevant here.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Status: Needs work » Postponed
Related issues: +#3002979: Convert OrganizationUiTest to BrowserTestBase

We definitely need to add the key, organization name is not a "Name" field in D8, its just a string as it should be.

However I'm not sure why tests are failed. Lets fix the tests first, postponing on #3002979: Convert OrganizationUiTest to BrowserTestBase.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Version: 8.x-1.x-dev » 8.x-3.x-dev
Status: Postponed » Needs review
RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Version: 8.x-3.x-dev » 8.x-1.x-dev
Assigned: Unassigned » grahl
Issue summary: View changes
FileSize
crm_core-3002667-10.patch1.29 KB

Ok, so when "label" entity key is set rendering system, or entity not sure, removes this field from the "content", thus failing test.

Attached patch removes redundant assertion.

However I'm not sure that supplied patch is enough. Maybe we need a follow up to review label handling for both contact types...

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Version: 8.x-1.x-dev » 8.x-3.x-dev

  • RoSk0 committed fec4c68 on 8.x-3.x authored by Juterpillar 
    Issue #3002667 by Juterpillar, RoSk0: Missing "label" entity key in...
RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Assigned: grahl » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.