Problem/Motivation

The existing \Drupal\Tests\memcache\Kernel\MemcacheBackendTest is failing:

Testing Drupal\Tests\memcache\Kernel\MemcacheBackendTest

ArgumentCountError : Too few arguments to function Drupal\memcache\MemcacheBackendFactory::__construct(), 2 passed in /.../d8/modules/memcache/tests/src/Kernel/MemcacheBackendTest.php on line 29 and exactly 3 expected
 /.../d8/modules/memcache/src/MemcacheBackendFactory.php:48
 /.../d8/modules/memcache/tests/src/Kernel/MemcacheBackendTest.php:29
 /.../d8/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php:97
 /.../d8/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php:131

Proposed resolution

  1. Fix the failing test.
  2. Enable automated testing on Drupal.org infrastructure.

Remaining tasks

  1. Fix the failing test.
  2. Enable automated testing on Drupal.org infrastructure.

User interface changes

To be determined.

API changes

To be determined.

Data model changes

To be determined.

CommentFileSizeAuthor
#3 3002490-3.patch821 bytesBeakerboy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Issue summary: View changes
Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
Status: Active » Needs review
FileSize
3002490-3.patch821 bytes

This patch resolves the exceptions and allows the tests to run.

Status: Needs review » Needs work

The last submitted patch, 3: 3002490-3.patch, failed testing. View results

Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
Status: Needs work » Needs review

Tests fail because the memcache extension does not exist on the CI. The code should probably mark the tests as skipped instead of throwing exceptions.

  • japerry committed 20aabb1 on 8.x-2.x authored by Beakerboy 
    Issue #3002490 by Beakerboy: Drupal\Tests\memcache\Kernel\...
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.