Problem/Motivation

Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Proposed resolution

Remaining tasks

Todo for maintainer: Update the name in project page accordingly

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 2998184-9.patch5.49 KBjungle
#7 2998184-7.patch780 bytesSuresh Prabhu Parkala
#3 after.png16.15 KBvolkswagenchick
#2 dropzonejs-info-2998184-2.patch239 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
dropzonejs-info-2998184-2.patch239 bytes

I uploaded a patch that Capitalize the name of the module in the .info.yml file.
Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
after.png16.15 KB

Code looks good. Patch applied via simplytest.me. Name of the module is now capitalized on the Extend page aligns with most of the other modules.

Screenshot attached. Marking RTBC.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

RTBC++.

It's a shame this one didn't make it into 8.x-2.1.

Don't forget to edit the name of the module here in drupal.org to also use the same capitalization.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Thanks everyone for working on this.

DropzoneJS is an open source library that provides drag’n’drop file uploads with image previews.

Per the description from the front page of https://www.dropzonejs.com, it's ok to call it DropzoneJS,

But in tests/modules/dropzonejs_test/dropzonejs_test.info.yml It's DropzoneJs Test, and in the description. it's Support module for DropzoneJs tests.. Setting back to NW for changing DropzoneJs to DropzoneJS

Todo for maintainer: Update the name in project page accordingly

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Issue summary: View changes

Todo for maintainer: Update the name in project page accordingly Done

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
2998184-7.patch780 bytes

Please review!

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Capitalize the name of the module in .info.yml file » Fix typos involving in DropzoneJS/dropzonejs
Assigned: Unassigned » jungle

Thanks @Suresh Prabhu Parkala!

I would rescope this to fixing DropzoneJS variations to DropzoneJS/dropzonejs where applicable, only changing the name does not make valuable sense to me. Assigning to myself.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
FileSize
2998184-9.patch5.49 KB

Addressing #8, no interdiff.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Assigned: jungle » Unassigned 
+++ b/tests/src/Kernel/DropzoneJsUploadControllerTest.php
@@ -11,9 +11,9 @@ use Symfony\Component\HttpFoundation\Request;
- * @group DropzoneJs
+ * @group dropzonejs

Should use dropzonejs -- the module's machine name after @group, see examples in the core, for example, https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/modules/menu...

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Reviewed & tested by the community

  • jungle committed c8eaf6e on 8.x-2.x 
    Issue #2998184 by jungle, alonaoneill, Suresh Prabhu Parkala,...
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.