Cannot Upgrade -White screen
Server error log:

PHP Parse error: syntax error, unexpected '[' in mysite.../modules/quiz/question_types/multichoice/multichoice.module on line 178

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quchidru created an issue. See original summary.

djdevin’s picture

Please upgrade to PHP 5.4+

Sorry this is not a listed requirement, I will add it.

vensires’s picture

We may be in the D8 era, but according to D7's PHP requirements, the short-syntax of the arrays should not be enforced. I believe it should be set back to array()

djdevin’s picture

Doesn't that page say that PHP 5.4 is the recommended minimum?

I noticed we are missing an info line for the requirement, but we can add it.

vensires’s picture

Recommended yes. Not unsupported. I wouldn't like to be the one to say no to upgrades, but the array() syntax isn't deprecated in PHP 7.0+ and that's why I stand against the [] syntax in D7.

joelpittet’s picture

Version: 7.x-5.3 » 7.x-5.x-dev
Status: Active » Needs review
FileSize
811 bytes

We are upgrading to 7 but it's a slow going process at educational institutions... pity us!

vensires’s picture

Status: Needs review » Reviewed & tested by the community
djdevin’s picture

Title: Update to 5.3 from 5.2 » Keep PHP 5.3+ compatibility

djdevin’s picture

Status: Reviewed & tested by the community » Fixed
djdevin’s picture

Since Quiz did not advertise that it needed 5.4 I have committed this.

However, in the future there may be a release that will be marked for a minimum version of PHP.

joelpittet’s picture

Thank you for pitying us!

steinmb’s picture

There might be more modules that drop older PHP 5 versions after core move to minimum 5.6.x (https://dri.es/the-end-of-php-5)

vensires’s picture

Title: Keep PHP 5.3+ compatibility » Keep array()s for PHP 5.3+ compatibility

Changed the title of the issue for better understanding of why this is not a blocker for PHP 7.2 support.
@steinmb Dropping older PHP 5 version support doesn't mean we should always use [] instead of array() since it is not even declared as deprecated yet.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.