Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We should add tests for things like:
- Apply a processor to an image - does it apply.
- Apply a processor to an image - is the original image okay even when it fails.
- Apply two processors to an image - are the processor effects compounded together in series.
- Apply a processor to an image that doesn't exist - what happens?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | imageapi_optimize-2996291-pipeline-tests.patch | 11.85 KB | Steven Jones |
| |||
| #3 | imageapi_optimize-2996291-pipeline-tests.patch | 11.84 KB | Steven Jones |
| |||
Comments
Comment #2
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #3
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedHere's the start of some tests, should cover those first three things in the issue description.
Probably better than nothing, and already shows a bug, but I've commented that out so we can get this in and fix that in another issue.
Comment #4
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedOdd, that test didn't get picked up.
Comment #5
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedGah! I renamed the class and not the file.
Comment #6
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedMuch more like it! Lets get these tests in, work on the last one, and the can fix the bug with the compound pipeline with failure in the middle.
Comment #9
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedAnd I've added that last test. So our first pass on this is done.