I'm running Drupal 6.4 and the 6.x-1.x-dev version of Comment Notify.

The email that is sent out by Comment Notify does not contain any line breaks for me at all. I checked this in Gmail and in Apple Mail. I looked at the code, and the standard carriage returns are there, but when it is then converted to email format, they must have gotten lost along the way. The whole comment notification email text just displays as one solid block. If you have any other questions for me about this, I'll be happy to respond - sorry if this bug report is too vague. I don't know what character sets my computer is using (I'm running OS X 10.5.4), although I know that character sets can cause many headaches among email programs.

CommentFileSizeAuthor
#5 comment_notify.patch1.32 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I've seen the same problem as well but I am not sure what is causing it.

It could be the html_to_text which is the one major change in this area from 5.x-> 6.x

archetwist’s picture

archetwist CreditAttribution: archetwist commented

Based on the fact that I have the same problem with both standard and "tokenized" e-mail actions I don't think the problem lies in this module.

archetwist’s picture

archetwist CreditAttribution: archetwist commented

Please take a look at my bug report at http://drupal.org/node/304535.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Hah! I think I know what's happening!! In comment_notify.module at line 323, $message['body'][] = ... should NOT call drupal_html_to_text because drupal_mail performs it for you and is unnecessary. I removed the call to drupal_html_to_text and the e-mails sent out just fine! Yay! Attaching patch shortly...

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
comment_notify.patch1.32 KB

Here's the patch for review. Works 100% on my site.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review

Dangit... I always forgot to change the status.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

It would seem there is definately something wrong with drupal_html_to_text, as reported in #298708: drupal_html_to_text() removes line endings. If we want to have any kind of nice formatting, we'll need to remove any calls to drupal_html_to_text, as presented in #5 until it gets fixed and backported. Otherwise e-mails sent by this module are just unreadable.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs review » Fixed

I've been testing this out on some sites but didn't get any comments on them :(

I just posted a comment myself and it works a treat. Thanks, Dave Reid! Committed: http://drupal.org/cvs?commit=139708

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.