Problem/Motivation
There are many helpful commands in the core/tests/README.md, like
brew install selenium-server-standalone
brew install chromedriver
and
export MINK_DRIVER_ARGS_WEBDRIVER='["chrome", null, "http://localhost:4444/wd/hub"]'
./vendor/bin/phpunit -c core --testsuite functional-javascript
Additionally, 90% of the command examples re-include the ./vendor/bin/phpunit part.
At first glance, it's not clear if that's on the same line as the needed command (it's not) or if it is required to run alongside the export commands (it's not).
And as it does not include trailing semicolons, pasting the block will not work
Proposed resolution
Add trailing semicolons to commands that should be run together and are on different lines
Consider removing the redundant ./vendor/bin/phpunit
portions from the set-up commands.
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#5 | commands-core-tests-readme-2995150-5.patch | 3.11 KB | msankhala |
Comments
Comment #2
volkswagenchickTagging for upcoming contribution days.
Comment #3
dawehnerComment #4
msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commentedI agree with adding the semicolon at the end of commands but I think it is fine if we keep `./vendor/bin/phpunit` part of the command instead of changing it to just `phpunit` because this is the correct path of the phpunit after you run `composer install`.
Comment #5
msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commentedHere is the patch.
Comment #6
tim.plunkettLooks great! I agree with not removing ./vendor/bin, not sure why I suggested that.
Comment #7
alexpottCommitted and pushed 93e12b09c9 to 8.7.x and b1a183acc0 to 8.6.x. Thanks!
Crediting @tim.plunkett for filing the issue.
As a docs fix backported to 8.6.x