The module i18n is responsible for the i18n variable translations and is listed as the source_module in migrations using the VariableTranslation source plugin therefor it needs to be removed from noUpgradePaths.

CommentFileSizeAuthor
#5 interdiff-2-5.txt1.02 KBgaurav.kapoor
#5 2988235-5.patch1.3 KBgaurav.kapoor
#2 2988235-2.patch521 bytesgaurav.kapoor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs for DrupalFit commented
Status: Active » Needs review
FileSize
2988235-2.patch521 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2988235-2.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

@gaurav.kapoor, thanks. 

+++ b/core/modules/migrate_drupal_ui/src/Form/ReviewForm.php
@@ -81,8 +81,6 @@ class ReviewForm extends MigrateUpgradeFormBase {
-      'i18nstrings',

This needs to stay in the list.

And then adjust MigrateUpgrade6I18nReviewPageTest so that i18n is in getMissingPaths() and not getAvailablePaths() and should fix this.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2988235-5.patch1.3 KB
interdiff-2-5.txt1.02 KB
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks for the quick turn around!

Applied that patch, had a think about to be sure, and yes it is correct. Tests are passing so this is ready.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue tags: +i18n-migrate

tagging

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue tags: +blocker

This needs to be committed before #2936365: Migrate UI - allow modules to declare the state of their migrations. Tagging as a blocker even though there is more work to do in that issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2fcd37d453 to 8.7.x and 6d18d39221 to 8.6.x. Thanks!

Backported to 8.6.x as a non-disruptive bug fix.

  • alexpott committed 2fcd37d on 8.7.x 
    Issue #2988235 by gaurav.kapoor, quietone: Remove i18n from d6 $...

  • alexpott committed 6d18d39 on 8.6.x 
    Issue #2988235 by gaurav.kapoor, quietone: Remove i18n from d6 $...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.