Problem/Motivation

\Drupal\Tests\layout_builder\Kernel\LayoutBuilderCompatibilityTestBase::assertFieldAttributes()
claims to return a string, but it does not

Proposed resolution

Remove the @return block

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 remove-return-doc-on-assertFieldAttributes-2987893-2.patch855 bytesdarchuletajr
#2 remove-return-doc-on-assertFieldAttributes-2987893-2.patch855 bytesdarchuletajr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

darchuletajr’s picture

darchuletajr CreditAttribution: darchuletajr as a volunteer commented
FileSize
remove-return-doc-on-assertFieldAttributes-2987893-2.patch855 bytes

Okay here is a patch that removes the return doc, is that all that should be done here?

darchuletajr’s picture

darchuletajr CreditAttribution: darchuletajr as a volunteer commented
Status: Active » Needs review
FileSize
remove-return-doc-on-assertFieldAttributes-2987893-2.patch855 bytes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Needs review » Reviewed & tested by the community

That's it, thanks!

The last submitted patch, 2: remove-return-doc-on-assertFieldAttributes-2987893-2.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed b90b91b47f to 8.7.x and 5cb125fa80 to 8.6.x. Thanks!

  • alexpott committed b90b91b on 8.7.x 
    Issue #2987893 by darchuletajr, tim.plunkett: Remove @return docs on \...

  • alexpott committed 5cb125f on 8.6.x 
    Issue #2987893 by darchuletajr, tim.plunkett: Remove @return docs on \...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Issue tags: +Blocks-Layouts

Retroactively tagging