Problem/Motivation

\Drupal\Tests\system\Functional\Entity\EntityReferenceSelection\EntityReferenceSelectionAccessTest is a browser test for historical reasons, it comes from D7 which didn't have kernel tests.

Proposed resolution

Convert it to a kernel test, which also makes it faster to run.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#3 interdiff-3.txt993 bytesamateescu
#3 2987084-3.patch5.47 KBamateescu
#2 2987084.patch5.47 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2987084.patch5.47 KB

There we go.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
FileSize
2987084-3.patch5.47 KB
interdiff-3.txt993 bytes

@timmillwood was confused about so many users called "admin_user" and suggested to rename the one from testNodeHandler() to $content_admin, and I agree :)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks @amateescu, looks good!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2987084-3.patch, failed testing. View results

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

  • catch committed a85b1ec on 8.7.x 
    Issue #2987084 by amateescu: Convert EntityReferenceSelectionAccessTest...

  • catch committed 1765cea on 8.6.x 
    Issue #2987084 by amateescu: Convert EntityReferenceSelectionAccessTest...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.7.x-dev » 8.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.7.x and cherry-picked to 8.6.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.