Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem / motivation
- Drupal 7 site has three languages enabled: EN (default), FI, SV
- UI language detection has URL and Default enabled
- Content language detection has URL, Interface and Default enabled
- Upgrade to Drupal 8 using Migrate Drupal UI
- Navigate to admin/config/regional/language/detection/url on your Drupal 8 site
- Try to save the language detection configuration.
- D8 does not allow saving the configuration and shows error message:
The domain for English, example.com, is not unique.
The domain for Finnish, example.com, is not unique.
The domain for Swedish, example.com, is not unique.
Categorizing this as Critical since the upgrade results into corrupted data that the site builder can't fix in the UI.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2985716-5.patch | 2.83 KB | maxocub |
#5 | 2985716-5-test-only.patch | 1.32 KB | maxocub |
Comments
Comment #2
masipila CreditAttribution: masipila as a volunteer commentedComment #3
masipila CreditAttribution: masipila as a volunteer commentedAdded to the parent meta.
Comment #4
maxocub CreditAttribution: maxocub as a volunteer commentedYou can fix this with the UI, if you switch to domain negotiation, you'll see the three same domains for your three languages. You can remove those domains and come back to prefix negotiation.
I'm working on a patch right now.
Comment #5
maxocub CreditAttribution: maxocub as a volunteer commentedThis is due to the fact that the Language source plugin and the LanguageDomains process plugin use 'domain_negotiation' both as a source configuration and a source property. This was causing the 'domain_negotiation' property to be always TRUE if the 'domain_negotiation' configuration was TRUE. I changed the name of the property.
Comment #7
masipila CreditAttribution: masipila as a volunteer commentedWhoa, that was fast @maxocub!
I'll test this when I get back home at the end of next week unless somebody else has already reviewed and tested this at that point of time.
Cheers,
Markus
Comment #8
masipila CreditAttribution: masipila as a volunteer commentedThere is a fail test that demonstrates the issue and the patch passes the new test.
I tested this manually and patch 5 resolves the issue as expected.
This is ready in my opinion. RTBC.
Cheers,
Markus
Comment #11
maxocub CreditAttribution: maxocub as a volunteer commentedTest bot hiccups, back to RTBC.
Comment #12
alexpottCommitted and pushed 37e09ab49c to 8.7.x and 5adaf06176 to 8.6.x. Thanks!
Comment #16
xjm