So um... THe should be The... I think the patch and the issue tag speak for themselves.

CommentFileSizeAuthor
#7 2984955-7.patch2.04 KBalexpott
#3 fix_default_factory_capitalization.patch759 bytesneclimdul
#2 fix_default_factory_capitalization.patch1.81 KBneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul at APQC commented
FileSize
fix_default_factory_capitalization.patch1.81 KB
neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul at APQC commented
Status: Active » Needs review
FileSize
fix_default_factory_capitalization.patch759 bytes

shoot, had some old patch work laying around. Real patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Seems to make sense in the context of english words.

Dinesh18’s picture

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented

Patch looks good. +1 to RTBC

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Title: Fix argument documentation capitalization » Fix THe to be The
Component: plugin system » documentation
FileSize
2984955-7.patch2.04 KB

There are 2 other none test instances of THe in our documentation. Personally I'd love to see a complete fix for this in something like #2829185: Fix spelling errors in Drupal core comments but that doesn't seem to be happening any time soon.

Anyhow as it is likely that any spellcheck of core is (at least in the short term) be done by PHPStorm's in built and this error is not picked up by that I think we should go ahead here and fix this.
The capitalisations tHe and thE do not exist in core and THE is used correctly.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul at APQC commented

sounds good. I don't want to speak for committers but until a larger solution, one off's like this don't seem too big a deal.

As Daniel put it "Seems to make sense in the context of english words." so still RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ae7bca02df to 8.7.x and 2a0adaa219 to 8.6.x. Thanks!

Backported to 8.6.x as this is a docs only change.

  • alexpott committed ae7bca0 on 8.7.x 
    Issue #2984955 by neclimdul, alexpott: Fix THe to be The

  • alexpott committed 2a0adaa on 8.6.x 
    Issue #2984955 by neclimdul, alexpott: Fix THe to be The

(cherry picked...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.