Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow up from #2982149: Routing: Convert system functional tests to phpunit
First apply patch from #4 then work on this.
At least this needs to be fixed:
$this->drupalGet('system-test/get-destination', ['query' => ['destination' => $test_case['input']]]);
$this->assertIdentical($test_case['output'], $this->getRawContent(), $test_case['message']);
// Test $_REQUEST['destination'].
$post_output = $this->drupalPost('system-test/request-destination', '*', ['destination' => $test_case['input']]);
$this->assertIdentical($test_case['output'], $post_output, $test_case['message']);
Comment | File | Size | Author |
---|---|---|---|
#21 | interdiff.txt | 1.75 KB | Mile23 |
#21 | 2983970_21.patch | 2.86 KB | Mile23 |
#16 | interdiff-2983970-14-16.txt | 811 bytes | ApacheEx |
#16 | 2983970-16.patch | 2.08 KB | ApacheEx |
Comments
Comment #2
scuba_flyComment #3
mitsuroseba CreditAttribution: mitsuroseba for Novasol commentedComment #4
scuba_flyPlease note that I'm splitting up #2982149: Routing: Convert system functional tests to phpunit
You can use the attached patch as starting point so this can be sumitted without waiting for #2982149
Comment #5
scuba_flyComment #6
scuba_flyAlso note the files are not in the right location in the patch #4 They need to be in System > Test > src >Routing
Comment #7
mitsuroseba CreditAttribution: mitsuroseba for Novasol commentedOkay.
Comment #8
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedHere it is.
Comment #10
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedRecreated patch. Should be better now.
Comment #12
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedHm, locally all tests are passed.
Let's try once more with minimum improvements.
Comment #14
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedlet's try once more.
Comment #16
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Internetdevels, Drupal Ukraine Community commentedWhat if that's the reason.
Comment #17
LendudeLooking at the fail for #2982149: Routing: Convert system functional tests to phpunit for the other router test, we should really include that in this conversion too, I think.
Comment #19
LendudeI take back #17
I took a look at converting the other routing test and that isn't easy at all. So lets keep this to a one test scope, or else it would drown in the other test.
This looks good.
Comment #21
Mile23Failed due to AssertLegacyTrait::getRawContent() being deprecated.
Comment #23
Mile23Testbot hiccup.
Comment #24
dawehnerI do like that it is easier to understand what is exactly in the HTTP response!
Comment #25
alexpottCommitted and pushed 5fee025533 to 8.7.x and 715786dd1e to 8.6.x. Thanks!