Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Style error information
https://eslint.org/docs/rules/operator-linebreak
How to Review
## 1. Apply Patch
## 2. Review Code Changes
## 3. Confirm no Code Standard Errors
yarn & yarn lint:core-js-passing
## 4.1 If `NO` errors, mark the issue as `Reviewed & tested by the community` (Don't be shy, we're all friendly)
## 4.2 If `HAS` errors, fix it and upload a new patch (Just do it and you can!!!)
Background
- #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core
- We adapted the airbnb coding standard (#2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib), but we are not fully compliant to it yet.
More Information
- Using ES6 in Core
https://www.drupal.org/node/2815083
- To find JS code standard errors stats
cd core/ && yarn & yarn lint:core-js-stats
Valuable Follow-up
- N/A
Comment | File | Size | Author |
---|---|---|---|
#16 | 2983365-16.patch | 2.52 KB | ApacheEx |
Comments
Comment #2
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedHere is a patch. I have also run
yarn run build:js
.Comment #3
m1r1k CreditAttribution: m1r1k commentedComment #4
alexpottNeed to update the patch due to changes to core.
Comment #5
m1r1k CreditAttribution: m1r1k commentedHere is a patch. I have also run
yarn run build:js
Comment #7
m1r1k CreditAttribution: m1r1k commentedHaven't updated from upstream :/
Here is reroll
Comment #8
anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commentedPatch applied successfully.
Marking it RTBC
Comment #10
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedRerolled + some small improvements.
To be honest this rule is weird. Not sure if we should go with it.
Even prettier prefers something like this:
Comment #11
GrandmaGlassesRopeMan@ApacheEx - I agree, this is strange. What about this configuration?
operator-linebreak: ["error", "after"]
Comment #12
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedCool, the patch looks much cleaner.
I also guess this rule should be placed in
.eslintrc.json
instead of.eslintrc.passing.json
Comment #13
GrandmaGlassesRopeMan@ApacheEx - 👏 Much nicer.
Comment #14
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedRerolled with the latest changes from 8.6.x
Comment #16
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Internetdevels, Drupal Ukraine Community commentedRerolled with 8.7.x
Comment #18
alexpottCommitted and pushed e15f82bfba to 8.7.x and 8ca7890875 to 8.6.x. Thanks!