Style error information

https://eslint.org/docs/rules/object-curly-newline

How to Review

## 1. Apply Patch
## 2. Review Code Changes
## 3. Confirm no Code Standard Errors
yarn & yarn lint:core-js-passing
## 4.1 If `NO` errors, mark the issue as `Reviewed & tested by the community` (Don't be shy, we're all friendly)
## 4.2 If `HAS` errors, fix it and upload a new patch (Just do it and you can!!!)

Background

- #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

- We adapted the airbnb coding standard (#2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib), but we are not fully compliant to it yet.

More Information

- Using ES6 in Core
https://www.drupal.org/node/2815083

- To find JS code standard errors stats
cd core/ && yarn & yarn lint:core-js-stats

Valuable Follow-up

- N/A

CommentFileSizeAuthor
#4 2983357-4.patch10.16 KBApacheEx
#3 2983357-3.patch5.26 KBApacheEx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drpal created an issue. See original summary.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented
Issue summary: View changes
Parent issue: » #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core
ApacheEx’s picture

ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commented
Status: Active » Needs review
FileSize
2983357-3.patch5.26 KB

Here is patch.

ApacheEx’s picture

ApacheEx CreditAttribution: ApacheEx as a volunteer and at Internetdevels, Drupal Ukraine Community commented
FileSize
2983357-4.patch10.16 KB

Forgot to run yarn run build:js

The last submitted patch, 3: 2983357-3.patch, failed testing. View results

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Crediting @drpal for issue management.

Committed c77b8b6 and pushed to 8.6.x. Thanks!

  • alexpott committed c77b8b6 on 8.6.x 
    Issue #2983357 by ApacheEx, drpal: JS codestyle: object-curly-newline

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.