Problem/Motivation

In Drupal 8.6, we want to make custom menu links usable with the Workspace module, which means they need to be revisionable and publishable. This issue has been split from #2880152: Convert custom menu links to be revisionable, and it handles only the publishable part.

Proposed resolution

Promote the existing enabled field to be the published entity key.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#8 2981915-8-followup.patch782 bytesamateescu
#4 interdiff-4.txt1.39 KBamateescu
#4 2981915-4.patch7.78 KBamateescu
#2 2981915.patch7.81 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2981915.patch7.81 KB

Patch split from #2880152: Convert custom menu links to be revisionable :)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Needs work

Only one minor nit pick.

+++ b/core/modules/menu_link_content/menu_link_content.install
@@ -16,3 +16,30 @@ function menu_link_content_install() {
+  // Add the published entity key and revisionable metadata fields to the

We're only adding the published entity key, not the revisionable metadata.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
2981915-4.patch7.78 KB
interdiff-4.txt1.39 KB

Oops, good catch :)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks, @amateescu, looks good to me now.

Should we port all credit back from #2880152: Convert custom menu links to be revisionable?

  • catch committed e2651fc on 8.6.x 
    Issue #2981915 by amateescu, timmillwood: Update MenuLinkContent to use...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed e2651fc and pushed to 8.6.x. Thanks!

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Fixed » Reviewed & tested by the community
FileSize
2981915-8-followup.patch782 bytes

It seems that I forgot a local debugging thingie in the patch, and also a typo :/

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

  • catch committed f9e6f92 on 8.6.x 
    Issue #2981915 by amateescu: (follow-up) Update MenuLinkContent to use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.