Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eli-T created an issue. See original summary.

Eli-T’s picture

Issue summary: View changes

The image currently being used is from the chocolate brownie recipe, which doesn't look like a disaster at all! Not sure if this was just a placeholder, so holding off on proposing alt text until we have guidance from @kjay.

Eli-T’s picture

Title: The baking mishaps article's image's alt text is "Alt text to be supplied" » Improve article image and alt text for Umami Baking Mishaps article
Status: Active » Postponed

After discussion with @kjay in Slack, we're going to replace the image with something more disastrous. No point updating the alt text until we have the new image.

andrewmacpherson’s picture

Issue tags: +Accessibility
Eli-T’s picture

Title: Improve article image and alt text for Umami Baking Mishaps article » Write alt text for Umami Baking Mishaps article
Priority: Normal » Major
Status: Postponed » Needs work
Issue tags: +DevDaysLisbon

In a complete volte-face from my previous comment, I've realised the alt text is an accessibility fail, so should be addressed, whilst the image is cosmetic and arguably shouldn't be changed unless we have a better example of shared images for media reuse. This is the only reused image.

Therefore changing scope of this issue to only address the alt text, unpostponing it and bumping the priority.

zuhair_ak’s picture

Status: Needs work » Needs review
FileSize
1.64 KB
zuhair_ak’s picture

Added headline as alt text since the image is a placeholder.

Eli-T’s picture

Status: Needs review » Needs work

Thanks for looking at this @zuhair_ak!

Your patch adds the alt text "Tips for troubleshooting baking mishaps." Unfortunately that is not appropriate alt text. The alt text is not an alternative to the title for the article, it should describe the contents of the image on which it is specified.

zuhair_ak’s picture

I though there is no image shown in the article from the issue summary. Changed it, Check if this is ok?

zuhair_ak’s picture

Accidentally added patch multiple times, removing one.

Eli-T’s picture

Status: Needs review » Needs work

This is definitely better. However, "Delicious chocolate brownie" isn't quite a correct sentence. Can I suggest "A delicious chocolate brownie" instead?

zuhair_ak’s picture

Status: Needs work » Needs review
FileSize
1.63 KB

That is better! Added patch with your changes.

Eli-T’s picture

Status: Needs review » Reviewed & tested by the community

I have reviewed this patch and tested it on SimplyTest.me. The text is good and shows up as the alt text in the appropriate places.

Marking RTBC.

Thanks @zuhair_ak

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs rerolling - the drop is moving.

pguillard’s picture

Status: Needs work » Needs review
FileSize
1.93 KB

Rerolled

Eli-T’s picture

Status: Needs review » Reviewed & tested by the community

Reroll looks good, applies cleanly and visually inspected on simplytest.me successfully. Thanks @pguillard!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9471842 and pushed to 8.6.x. Thanks!

  • alexpott committed 9471842 on 8.6.x
    Issue #2981351 by zuhair_ak, pguillard, Eli-T: Write alt text for Umami...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.