The image currently being used is from the chocolate brownie recipe, which doesn't look like a disaster at all! Not sure if this was just a placeholder, so holding off on proposing alt text until we have guidance from @kjay.
The baking mishaps article's image's alt text is "Alt text to be supplied"
» Improve article image and alt text for Umami Baking Mishaps article
Status:
Active
» Postponed
After discussion with @kjay in Slack, we're going to replace the image with something more disastrous. No point updating the alt text until we have the new image.
In a complete volte-face from my previous comment, I've realised the alt text is an accessibility fail, so should be addressed, whilst the image is cosmetic and arguably shouldn't be changed unless we have a better example of shared images for media reuse. This is the only reused image.
Therefore changing scope of this issue to only address the alt text, unpostponing it and bumping the priority.
Your patch adds the alt text "Tips for troubleshooting baking mishaps." Unfortunately that is not appropriate alt text. The alt text is not an alternative to the title for the article, it should describe the contents of the image on which it is specified.
This is definitely better. However, "Delicious chocolate brownie" isn't quite a correct sentence. Can I suggest "A delicious chocolate brownie" instead?
Comments
Comment #2
Eli-TThe image currently being used is from the chocolate brownie recipe, which doesn't look like a disaster at all! Not sure if this was just a placeholder, so holding off on proposing alt text until we have guidance from @kjay.
Comment #3
Eli-TAfter discussion with @kjay in Slack, we're going to replace the image with something more disastrous. No point updating the alt text until we have the new image.
Comment #4
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedComment #5
Eli-TIn a complete volte-face from my previous comment, I've realised the alt text is an accessibility fail, so should be addressed, whilst the image is cosmetic and arguably shouldn't be changed unless we have a better example of shared images for media reuse. This is the only reused image.
Therefore changing scope of this issue to only address the alt text, unpostponing it and bumping the priority.
Comment #6
zuhair_akComment #7
zuhair_akAdded headline as alt text since the image is a placeholder.
Comment #8
Eli-TThanks for looking at this @zuhair_ak!
Your patch adds the alt text "Tips for troubleshooting baking mishaps." Unfortunately that is not appropriate alt text. The alt text is not an alternative to the title for the article, it should describe the contents of the image on which it is specified.
Comment #9
zuhair_akI though there is no image shown in the article from the issue summary. Changed it, Check if this is ok?
Comment #10
zuhair_akAccidentally added patch multiple times, removing one.
Comment #11
Eli-TThis is definitely better. However, "Delicious chocolate brownie" isn't quite a correct sentence. Can I suggest "A delicious chocolate brownie" instead?
Comment #12
zuhair_akThat is better! Added patch with your changes.
Comment #13
Eli-TI have reviewed this patch and tested it on SimplyTest.me. The text is good and shows up as the alt text in the appropriate places.
Marking RTBC.
Thanks @zuhair_ak
Comment #14
alexpottNeeds rerolling - the drop is moving.
Comment #15
pguillard CreditAttribution: pguillard commentedRerolled
Comment #16
Eli-TReroll looks good, applies cleanly and visually inspected on simplytest.me successfully. Thanks @pguillard!
Comment #17
alexpottCommitted 9471842 and pushed to 8.6.x. Thanks!