Cache context ID: 'site'.

The correct ID of this context is 'url.site'.

CommentFileSizeAuthor
#5 2979166-5.patch606 bytesrajeevk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

lomasr’s picture

lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented

As per the working example

cache_context.url.site:
class: Drupal\Core\Cache\Context\SiteCacheContext
arguments: ['@request_stack']
tags:

I think it should be 'url.site'

lomasr’s picture

lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Active » Needs review
Chi’s picture

Chi CreditAttribution: Chi commented
Title: Wrong documentation on SiteCacheContext » Wrong documentation on SiteCacheContext class
Status: Needs review » Needs work

@lomasr, there is no patch to review

rajeevk’s picture

rajeevk
Location London
CreditAttribution: rajeevk as a volunteer and at Sirius commented
Status: Needs work » Needs review
FileSize
2979166-5.patch606 bytes

Attaching patch as per @ lomasr comment

lomasr’s picture

lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented

#4 My Mistake. I should have marked it "need work".

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Reviewed & tested by the community

Thanks.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

  • Gábor Hojtsy committed 41c88ee on 8.6.x 
    Issue #2979166 by RajeevK, lomasr: Wrong documentation on...

  • Gábor Hojtsy committed 66397c7 on 8.5.x 
    Issue #2979166 by RajeevK, lomasr: Wrong documentation on...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Good catch, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.