Drupal code sniffer is giving the following warning in all of the test files - Namespaced classes/interfaces/traits should be referenced with use statements .

The use statements should be refactored to Drupal standards.

File attached with the warnings.

CommentFileSizeAuthor
#2 marketing_cloud-dupal_standards_namespacing-2976971-2.patch18.47 KBjohn_a
drupalcs-report.txt8.49 KBjohn_a
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

john_a created an issue. See original summary.

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Issue summary: View changes
Status: Active » Needs review
FileSize
marketing_cloud-dupal_standards_namespacing-2976971-2.patch18.47 KB

Patch created, please review.

code sniffer report:

$ drupalcs .

FILE: ...eting_cloud/modules/marketing_cloud_assets/src/AssetsService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
84 | WARNING | Line exceeds 80 characters; contains 186 characters
----------------------------------------------------------------------

FILE: ...es/custom/marketing_cloud/modules/marketing_cloud_push/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 29 WARNINGS AFFECTING 29 LINES
----------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 101 characters
29 | WARNING | Line exceeds 80 characters; contains 101 characters
30 | WARNING | Line exceeds 80 characters; contains 101 characters
31 | WARNING | Line exceeds 80 characters; contains 101 characters
32 | WARNING | Line exceeds 80 characters; contains 101 characters
33 | WARNING | Line exceeds 80 characters; contains 101 characters
34 | WARNING | Line exceeds 80 characters; contains 101 characters
35 | WARNING | Line exceeds 80 characters; contains 101 characters
36 | WARNING | Line exceeds 80 characters; contains 101 characters
37 | WARNING | Line exceeds 80 characters; contains 101 characters
38 | WARNING | Line exceeds 80 characters; contains 101 characters
39 | WARNING | Line exceeds 80 characters; contains 101 characters
40 | WARNING | Line exceeds 80 characters; contains 101 characters
41 | WARNING | Line exceeds 80 characters; contains 101 characters
42 | WARNING | Line exceeds 80 characters; contains 101 characters
43 | WARNING | Line exceeds 80 characters; contains 101 characters
44 | WARNING | Line exceeds 80 characters; contains 101 characters
45 | WARNING | Line exceeds 80 characters; contains 101 characters
46 | WARNING | Line exceeds 80 characters; contains 101 characters
47 | WARNING | Line exceeds 80 characters; contains 101 characters
48 | WARNING | Line exceeds 80 characters; contains 101 characters
49 | WARNING | Line exceeds 80 characters; contains 101 characters
50 | WARNING | Line exceeds 80 characters; contains 101 characters
51 | WARNING | Line exceeds 80 characters; contains 101 characters
52 | WARNING | Line exceeds 80 characters; contains 101 characters
53 | WARNING | Line exceeds 80 characters; contains 101 characters
54 | WARNING | Line exceeds 80 characters; contains 101 characters
55 | WARNING | Line exceeds 80 characters; contains 101 characters
56 | WARNING | Line exceeds 80 characters; contains 101 characters
----------------------------------------------------------------------

FILE: ...marketing_cloud/modules/marketing_cloud_push/src/PushService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
23 | WARNING | Line exceeds 80 characters; contains 148 characters
97 | WARNING | Line exceeds 80 characters; contains 148 characters
358 | WARNING | Line exceeds 80 characters; contains 182 characters
----------------------------------------------------------------------

FILE: ...ustom/marketing_cloud/modules/marketing_cloud_contacts/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 22 WARNINGS AFFECTING 22 LINES
----------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 100 characters
29 | WARNING | Line exceeds 80 characters; contains 100 characters
30 | WARNING | Line exceeds 80 characters; contains 100 characters
31 | WARNING | Line exceeds 80 characters; contains 100 characters
32 | WARNING | Line exceeds 80 characters; contains 100 characters
33 | WARNING | Line exceeds 80 characters; contains 100 characters
34 | WARNING | Line exceeds 80 characters; contains 100 characters
35 | WARNING | Line exceeds 80 characters; contains 100 characters
36 | WARNING | Line exceeds 80 characters; contains 100 characters
37 | WARNING | Line exceeds 80 characters; contains 100 characters
38 | WARNING | Line exceeds 80 characters; contains 100 characters
39 | WARNING | Line exceeds 80 characters; contains 100 characters
40 | WARNING | Line exceeds 80 characters; contains 100 characters
41 | WARNING | Line exceeds 80 characters; contains 100 characters
42 | WARNING | Line exceeds 80 characters; contains 100 characters
43 | WARNING | Line exceeds 80 characters; contains 100 characters
44 | WARNING | Line exceeds 80 characters; contains 100 characters
45 | WARNING | Line exceeds 80 characters; contains 100 characters
46 | WARNING | Line exceeds 80 characters; contains 100 characters
47 | WARNING | Line exceeds 80 characters; contains 100 characters
48 | WARNING | Line exceeds 80 characters; contains 100 characters
49 | WARNING | Line exceeds 80 characters; contains 100 characters
----------------------------------------------------------------------

FILE: ...g_cloud/modules/marketing_cloud_contacts/src/ContactsService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
23 | WARNING | Line exceeds 80 characters; contains 91 characters
36 | WARNING | Line exceeds 80 characters; contains 92 characters
52 | WARNING | Line exceeds 80 characters; contains 87 characters
68 | WARNING | Line exceeds 80 characters; contains 84 characters
100 | WARNING | Line exceeds 80 characters; contains 113 characters
148 | WARNING | Line exceeds 80 characters; contains 116 characters
170 | WARNING | Line exceeds 80 characters; contains 116 characters
208 | WARNING | Line exceeds 80 characters; contains 112 characters
225 | WARNING | Line exceeds 80 characters; contains 84 characters
241 | WARNING | Line exceeds 80 characters; contains 94 characters
257 | WARNING | Line exceeds 80 characters; contains 113 characters
300 | WARNING | Line exceeds 80 characters; contains 142 characters
----------------------------------------------------------------------

FILE: ...om/marketing_cloud/modules/marketing_cloud_data_events/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 125 characters
29 | WARNING | Line exceeds 80 characters; contains 125 characters
30 | WARNING | Line exceeds 80 characters; contains 125 characters
31 | WARNING | Line exceeds 80 characters; contains 125 characters
32 | WARNING | Line exceeds 80 characters; contains 125 characters
----------------------------------------------------------------------

FILE: ...stom/marketing_cloud/modules/marketing_cloud_campaigns/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 83 characters
29 | WARNING | Line exceeds 80 characters; contains 83 characters
30 | WARNING | Line exceeds 80 characters; contains 83 characters
31 | WARNING | Line exceeds 80 characters; contains 83 characters
32 | WARNING | Line exceeds 80 characters; contains 83 characters
33 | WARNING | Line exceeds 80 characters; contains 83 characters
34 | WARNING | Line exceeds 80 characters; contains 83 characters
35 | WARNING | Line exceeds 80 characters; contains 83 characters
36 | WARNING | Line exceeds 80 characters; contains 83 characters
37 | WARNING | Line exceeds 80 characters; contains 83 characters
----------------------------------------------------------------------

FILE: ...om/marketing_cloud/modules/marketing_cloud_interaction/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
----------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 87 characters
29 | WARNING | Line exceeds 80 characters; contains 87 characters
30 | WARNING | Line exceeds 80 characters; contains 87 characters
31 | WARNING | Line exceeds 80 characters; contains 87 characters
32 | WARNING | Line exceeds 80 characters; contains 87 characters
33 | WARNING | Line exceeds 80 characters; contains 87 characters
34 | WARNING | Line exceeds 80 characters; contains 87 characters
35 | WARNING | Line exceeds 80 characters; contains 87 characters
36 | WARNING | Line exceeds 80 characters; contains 87 characters
37 | WARNING | Line exceeds 80 characters; contains 87 characters
38 | WARNING | Line exceeds 80 characters; contains 87 characters
39 | WARNING | Line exceeds 80 characters; contains 87 characters
40 | WARNING | Line exceeds 80 characters; contains 87 characters
41 | WARNING | Line exceeds 80 characters; contains 87 characters
----------------------------------------------------------------------

FILE: ...d/modules/marketing_cloud_interaction/src/InteractionService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
23 | WARNING | Line exceeds 80 characters; contains 173 characters
36 | WARNING | Line exceeds 80 characters; contains 493 characters
52 | WARNING | Line exceeds 80 characters; contains 311 characters
97 | WARNING | Line exceeds 80 characters; contains 126 characters
113 | WARNING | Line exceeds 80 characters; contains 462 characters
145 | WARNING | Line exceeds 80 characters; contains 179 characters
171 | WARNING | Line exceeds 80 characters; contains 140 characters
196 | WARNING | Line exceeds 80 characters; contains 199 characters
246 | WARNING | Line exceeds 80 characters; contains 124 characters
265 | WARNING | Line exceeds 80 characters; contains 143 characters
----------------------------------------------------------------------

FILE: ...les/custom/marketing_cloud/modules/marketing_cloud_sms/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES
----------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 103 characters
29 | WARNING | Line exceeds 80 characters; contains 103 characters
30 | WARNING | Line exceeds 80 characters; contains 103 characters
31 | WARNING | Line exceeds 80 characters; contains 103 characters
32 | WARNING | Line exceeds 80 characters; contains 103 characters
33 | WARNING | Line exceeds 80 characters; contains 103 characters
34 | WARNING | Line exceeds 80 characters; contains 103 characters
35 | WARNING | Line exceeds 80 characters; contains 103 characters
36 | WARNING | Line exceeds 80 characters; contains 103 characters
37 | WARNING | Line exceeds 80 characters; contains 103 characters
38 | WARNING | Line exceeds 80 characters; contains 103 characters
39 | WARNING | Line exceeds 80 characters; contains 103 characters
40 | WARNING | Line exceeds 80 characters; contains 103 characters
41 | WARNING | Line exceeds 80 characters; contains 103 characters
42 | WARNING | Line exceeds 80 characters; contains 103 characters
43 | WARNING | Line exceeds 80 characters; contains 103 characters
44 | WARNING | Line exceeds 80 characters; contains 103 characters
45 | WARNING | Line exceeds 80 characters; contains 103 characters
46 | WARNING | Line exceeds 80 characters; contains 103 characters
47 | WARNING | Line exceeds 80 characters; contains 103 characters
48 | WARNING | Line exceeds 80 characters; contains 103 characters
49 | WARNING | Line exceeds 80 characters; contains 103 characters
50 | WARNING | Line exceeds 80 characters; contains 103 characters
51 | WARNING | Line exceeds 80 characters; contains 103 characters
----------------------------------------------------------------------

FILE: ...m/marketing_cloud/modules/marketing_cloud_sms/src/SMSService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
55 | WARNING | Line exceeds 80 characters; contains 92 characters
274 | WARNING | Line exceeds 80 characters; contains 191 characters
----------------------------------------------------------------------

  • john_a committed bc43d0a on 8.x-1.x 
    Issue #2976971 by john_a: Namespaced classes/interfaces/traits should be...
john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Needs review » Fixed

Fix tested by self: Patch applies ok, all test pass, drupalcs reports no more warnings.

committing the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.