The class Drupal\memcache\MemcacheBackendFactory must implement Drupal\Core\Cache\CacheFactoryInterface, otherwise this factory class is not properly integrated into the Drupal ecosystem.

This can lead to fatals on service layers, service exchanges, documentation problems and general API usage.

CommentFileSizeAuthor
#2 2976241-implement-cachefactoryinterface-1.patch600 bytesmxh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mxh created an issue. See original summary.

mxh’s picture

mxh
Primary language German
Location Offenburg
CreditAttribution: mxh as a volunteer and at Hubert Burda Media commented
Status: Active » Needs review
FileSize
2976241-implement-cachefactoryinterface-1.patch600 bytes
MiSc’s picture

MiSc CreditAttribution: MiSc commented
Status: Needs review » Reviewed & tested by the community

Yes, this make sense.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Issue tags: +beta blocker
Parent issue: » #2989594: [META] Create a stable release of Memcache module for Drupal 8

Tagging as a beta blocker, per #2989594: [META] Create a stable release of Memcache module for Drupal 8.

bdragon’s picture

bdragon CreditAttribution: bdragon at Tag1 Consulting for Acquia commented
Assigned: Unassigned » bdragon

Agreed. I've been testing this locally and it looks correct. I'll get this in tomorrow. (Didn't realize until now that I don't actually have a commit bit on memcache and I'd rather not add myself to the project without an explicit OK from Jeremy first.)

  • mxh authored 3c415e6 on 8.x-2.x 
    Issue #2976241 by mxh: class MemcacheBackendFactory does not implement...
bdragon’s picture

bdragon CreditAttribution: bdragon at Tag1 Consulting for Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.