Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We need to port the D7 feeds_tamper Time to Date plugin to D8 tamper.
Comment | File | Size | Author |
---|---|---|---|
#14 | timetodate-2976187-14.patch | 538 bytes | jamesdixon |
#11 | timetodate-2976187-11.patch | 3.44 KB | mmaranao |
#8 | interdiff-2976187-5-8.txt | 2.93 KB | vijay.mayilsamy |
#8 | timetodate-2976187-8.patch | 3.26 KB | vijay.mayilsamy |
#5 | timetodate-2976187-5.patch | 3.54 KB | vijay.mayilsamy |
Comments
Comment #2
sivaramakrishnan CreditAttribution: sivaramakrishnan as a volunteer and commentedPlease Apply the Here attached Patch and this patch for port the Time to Date Plugin from D7 to D8.
Comment #3
ericgsmith CreditAttribution: ericgsmith as a volunteer commentedThanks @sivaramakrishnan - this one will also need a test before we can commit.
Comment #4
vijay.mayilsamy CreditAttribution: vijay.mayilsamy as a volunteer and at Dialed In Design commentedHi @ericgsmith,
Here is the updated patch includes the test for time to date plugin, schema updates and fixes on the plugin code.
Thanks
Vijay
Comment #5
vijay.mayilsamy CreditAttribution: vijay.mayilsamy as a volunteer and at Dialed In Design commentedCoding standard fix applied to test file
Comment #6
jamesdixon CreditAttribution: jamesdixon at Dialed In Design commentedMoving to needs review.
Comment #7
ericgsmith CreditAttribution: ericgsmith as a volunteer commentedThanks Vijay - few minor comments.
Setting the form to required would make this redundant.
Would be good to throw an exception if data is not numeric first.
Can use $this->plugin here
Comment #8
vijay.mayilsamy CreditAttribution: vijay.mayilsamy as a volunteer and at Dialed In Design commentedHi Ericgsmith,
Thanks for the feedback. Here is the updated patch and interdiff after working on the feedback.
Thanks
Vijay
Comment #9
ericgsmith CreditAttribution: ericgsmith as a volunteer commentedComment #10
jfarry CreditAttribution: jfarry commentedThis one is working well for me. How many do we need for an RTBC?
Thank you vijay.mayilsamy :)
Comment #11
mmaranao CreditAttribution: mmaranao commentedI'd like to submit this patch to add the timetodate plugin against the latest alpha1 release
Comment #13
jamesdixon CreditAttribution: jamesdixon at Dialed In Design commentedCommitted to 8.x-1.x. Thanks everyone!
Comment #14
jamesdixon CreditAttribution: jamesdixon at Dialed In Design commentedSorry guys tests needed updating to modern architecture.
Testing this patch.
Comment #16
jamesdixon CreditAttribution: jamesdixon at Dialed In Design commentedTests fixed in commit: e106cc72be9982592fbafe5011bcc80fa542c09e