JSONAPI Extras module allows selecting a field enhancer for "fields" (attributes) of config entities in the admin UI. It, however, does not apply any field enhancer to config entities because config entities have no concept of fields.

This patch is to iterate over the exported attributes of config entities and apply the configured enhancers.

CommentFileSizeAuthor
#10 jsonapi_extras-config_entities_enhancer-2975925-10.patch1.66 KBsonnykt
#5 jsonapi_extras-config_entities_enhancer-2975925-5.patch1.15 KBsonnykt
#2 jsonapi_extras-config_entities_enhancer-2975925-2.patch2.21 KBsonnykt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sonnykt created an issue. See original summary.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
FileSize
jsonapi_extras-config_entities_enhancer-2975925-2.patch2.21 KB
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: jsonapi_extras-config_entities_enhancer-2975925-2.patch, failed testing. View results

sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
FileSize
jsonapi_extras-config_entities_enhancer-2975925-5.patch1.15 KB
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
Status: Needs work » Needs review
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Needs work

This is looking good. We need the other half as well. This is when we transform data coming in so it matches the internal format. This should use the doTransform(…) method.

Thanks for reporting and for providing a working patch!

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

@sonnykt do you think you'll get a chance to look into this again?

sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented

@e0ipso sorry I was busy these days. I'll try to submit another patch in next few days.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
FileSize
jsonapi_extras-config_entities_enhancer-2975925-10.patch1.66 KB

New patch to apply enhancer on incoming data.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
Status: Needs work » Needs review

  • e0ipso committed f67e2ad on 8.x-2.x authored by sonnykt 
    Issue #2975925 by sonnykt, e0ipso: Field enhancer does not work with...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Priority: Normal » Critical

Thanks for the fix @sonnykt! This was a very good catch.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.