When looking for an entity with the same name, restrict search to entities within the same bundle

It looks like that you have accidentally removed the feeds_item field on your vocabulary. Resave the feed type and try again.

I'm considering in making the feeds_item field a base field on the entity so that you can no longer accidentally remove it and break your import. I've experimented with that idea in #2799225-14: The "hidden" plugin does not exist: Drupal\Component\Plugin\Exception\PluginNotFoundException:.

Yes, it's quite a hassle to uninstall Feeds. It could probably be made a bit easier if the feeds_item field was a base field. But do indeed individual tamper definitions need to be removed first too? I would think it would be enough to just delete the feed types and then the tamper plugin instances would be deleted with them. This is because the tamper plugin instances are saved on the feed type itself.

Note: on the uninstall modules page there is a link to delete all feed entities.

Hm, I think this is caused by the following issue: #2820548: Fatal error when triggering Feeds via cron .

If you deleted a feed type for which an import is still in progress, the import task remains in the queue. And when the import task runs, it cannot find the feed type, fails with an error similar as above and holds up other import tasks in the queue. Can you try the patch from #2820548-15: Fatal error when triggering Feeds via cron and see if that fixes your issue? The error reported in the other issue is different though (Call to a member function hasTranslation() on null), so maybe it doesn't help.

Or did you perform an import using the UI?

Wait, you did. Else you would not have gotten an AJAX error.

Can you try to reproduce the issue on a fresh install of Drupal? To rule out possible module conflicts?

That's interesting. Does the same error occur if you only import lines 497 - 499 from the CSV file?

This bug looks like one that would be hard to reproduce without knowing how your configuration exactly looks like and what content you are trying to import. If you can share your configuration and a file that triggers the error, that would be helpful. Sharing configuration can be done with a feature module. Make sure that the feature module contains the following:

• The Feed type;
• The vocabulary selected on the processor;
• Fields used on your vocabulary;
• Field storage items of your fields;
• Optionally other configuration that is related.

Tamper plugin instances are stored on the feed type in D8.

@ksc
I took me a few days before I could find time to look at this. I've found the cause of the issue! The issue is as follows:

1. 'Suchbegriff -> Term name' is set as unique target.
2. You importing terms to other taxonomies as well.
3. At a certain point the term 'Schmerzen' gets added to the vocabulary 'Zuordnung funktional'.
4. When Feeds comes across the term 'Schmerzen' in the column 'Suchbegriff', it tries to find a term with the same name.
5. Feeds happens to not restrict that search to the vocabulary it imports terms for and finds a term called 'Schmerzen' in the vocabulary 'Zuordnung funktional'. This vocabulary does not have a feeds_item field and thus an error happens.

Conclusion: there is a bug in Feeds: when setting the term name as unique target, Feeds fails to restrict to search for an existing entity within the same vocabulary.

Possible workaround: Map 'Suchbegriff' also to 'Feeds item: Item GUID' and use that as unique target instead.

@ksc
You are right that if you add mapping to 'Feeds item: Item GUID' and set that as unique right away, the vocabulary needs to be empty as it else would lead to duplicates.

You could however add the mapping to 'Feeds item: Item GUID', keep 'Term name' as the unique target and import all records again that could be imported without errors. Then all imported terms will have a value for 'Feeds item: Item GUID'. You can then switch over to use 'Feeds item: Item GUID' as unique target and duplicates will be avoided.

Actually, I have the same problem with two node importers, both of them has the same GUID integer value for different two fields and different bundles.

This is because the following line of code in existingEntityId() returns a conflict GUID because it doesn't restrict the query to the bundle:

$entity_id = $plugin->getUniqueValue($feed, $mapping['target'], $key, $item->get($mapping['map'][$key]));

And sometimes it returns a warning 'Field field_name_goes_here is unknown' when it finds a GUID of the other content type and not match the importer bundle or content type.

The following patch will add an extra condition by the bundle key and bundle value and it works in my case.

I had a similar problem, when trying to update nodes using their title as a unique identifier. The patch worked to resolve my issue. Commenting here to say thank you!

I was facing the same issue when importing taxonomies. The feed type has the "Update existing taxonomy terms" flagged and "Name" as Unique lookup.

I've applied the patch provided by Omar on #18 solved my issue.

Thanks,
Carol

I think that the reason that the test failed is because not every entity type has a bundle key.

New patch, also with a test. Tests only patch should fail.

Tests are passing now and the test only patch demonstrates the issue.

Committed #23.

Crediting the reviewers.