Problem/Motivation

That method has this line:

$form['submit']['#weight'] = 10;

If there are any exposed sorts. But $form['submit'] doesn't exist, as other lines further up show, that is now inside a separate 'actions' key.

Proposed resolution

Remoe that that, actions means it is already ensured to have a weight of 99 or so and since this doesn't do anything, it's also not necessary.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 views-exposed-submit-remove-weight-2974640-11.patch631 bytesmrinalini9
#2 views-exposed-submit-remove-weight-2974640-2.patch625 bytesilya.no
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

ilya.no’s picture

ilya.no CreditAttribution: ilya.no as a volunteer and at Skilld for Skilld commented
Status: Active » Needs review
FileSize
views-exposed-submit-remove-weight-2974640-2.patch625 bytes

Check, please, attached patch.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kkalashnikov’s picture

kkalashnikov CreditAttribution: kkalashnikov at Srijan | A Material+ Company commented

Patch #2 is working fine for me moved to RTBC

kkalashnikov’s picture

kkalashnikov CreditAttribution: kkalashnikov at Srijan | A Material+ Company commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 1c259a5 and pushed to 9.1.x. Thanks!

Going to ping to other committers for a backport to 9.0.x and 8.9.x as these are in RC.

  • alexpott committed 1c259a5 on 9.1.x 
    Issue #2974640 by ilya.no, Berdir: ExposedFormPluginBase::...
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Patch (to be ported) » Needs review
FileSize
views-exposed-submit-remove-weight-2974640-11.patch631 bytes

Added patch for 8.9.x, please review.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Patch (to be ported)

revert status

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

@mrinalini9 the patch in #2 applied to 8.9.x already.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Patch (to be ported) » Fixed

Discussed with @catch and cherry-picked this back to 8.9.x

  • alexpott committed f7639cf on 9.0.x 
    Issue #2974640 by ilya.no, Berdir: ExposedFormPluginBase::...

  • alexpott committed d1a21fe on 8.9.x 
    Issue #2974640 by ilya.no, Berdir: ExposedFormPluginBase::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.