In #2968559: Add admin links for admin toolbar admin links were added for Feeds. It would be useful to add Tamper to the menu as well. Additionally, the 'Tamper' link could be added as an operation on the feed type overview page. This was done for 'Mapping' in Feeds as well in #2967631: Add a "Mapping" operation to the feed type overview.

Patch will follow.

CommentFileSizeAuthor
#5 interdiff-2974245-3-5.txt1.66 KBMegaChriz
#5 feeds_tamper-admin-links-2974245-5.patch4.02 KBMegaChriz
#3 feeds_tamper-admin-links-2974245-3.patch3.43 KBMegaChriz
#2 feeds_tamper-admin-links-2974245-2.patch1.84 KBMegaChriz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MegaChriz created an issue. See original summary.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Active » Needs review
FileSize
feeds_tamper-admin-links-2974245-2.patch1.84 KB

It would be useful to have tests for this as well.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
FileSize
feeds_tamper-admin-links-2974245-3.patch3.43 KB

Working on the tests. The test currently fails on "Invalid permission tamper my_feed_type". How can I get the permissions to be rebuild during tests after the feed type is created?

Status: Needs review » Needs work

The last submitted patch, 3: feeds_tamper-admin-links-2974245-3.patch, failed testing. View results

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs work » Needs review
FileSize
feeds_tamper-admin-links-2974245-5.patch4.02 KB
interdiff-2974245-3-5.txt1.66 KB

Maybe I should just enable feeds_tamper module in the test :D.

  • MegaChriz committed 70f9d01 on 8.x-2.x 
    Issue #2974245 by MegaChriz: Added admin links for admin toolbar.
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Fixed

Committed #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.