InteractionService->searchJourneys() params should have default [] [#2974054]

InteractionService->searchJourneys() input contract is:

searchJourneys(array $params, $json = NULL)

This should be changed to:

searchJourneys(array $params - NULL, $json = NULL)

because it is possible to search for journeys without filters, and it should not be up to the calling code to define an empty array.

Comment	File	Size	Author
#4	marketing_cloud-searchJourneys_params-2974054-4.patch	1.86 KB	john_a
#4
#2	marketing_cloud-searchJourneys_params-2974054-2.patch	928 bytes	john_a
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 May 2018 at 00:55

john_a created an issue. See original summary.

Comment #2

john_a CreditAttribution: john_a as a volunteer commented 21 May 2018 at 12:14

File	Size
marketing_cloud-searchJourneys_params-2974054-2.patch	928 bytes

Patch created, please review

Comment #3

john_a CreditAttribution: john_a as a volunteer commented 21 May 2018 at 12:14

Status:

Active

» Needs review

Comment #4

john_a CreditAttribution: john_a as a volunteer commented 23 May 2018 at 22:56

File	Size
marketing_cloud-searchJourneys_params-2974054-4.patch	1.86 KB

Patch was incorrect - it applied $params to URL tokens and URL params.

Patch recreated and added unit test for no params.

Please review. Expected results:

$ ../vendor/bin/phpunit --filter=MarketingCloudInteractionTest
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

Testing
.

Time: 3.18 minutes, Memory: 216.00MB

OK (1 test, 89 assertions)

Comment #5

john_a CreditAttribution: john_a as a volunteer commented 24 May 2018 at 05:09

Status:

Needs review

» Reviewed & tested by the community

patch applies cleanly, unit tests pass:

/core$ ../vendor/bin/phpunit --filter=MarketingCloudInteractionTest
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

Testing
.

Time: 3.11 minutes, Memory: 216.00MB

OK (1 test, 91 assertions)

HTML output was generated