While reading MigrateField.php I discoveted an extra "must" in a docblock which is redundant.

CommentFileSizeAuthor
#6 drupal-remove_must-2973954-6.patch637 bytesjuampynr
#4 removed_redudant_must-2973954-3.patch669 bytesdhirendra.mishra
#2 drupal-remove_must-2973954-2.patch637 bytesjuampynr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juampynr created an issue. See original summary.

juampynr’s picture

juampynr CreditAttribution: juampynr at Lullabot commented
Status: Active » Needs review
FileSize
drupal-remove_must-2973954-2.patch637 bytes

Here is a patch that fixes it.

Status: Needs review » Needs work

The last submitted patch, 2: drupal-remove_must-2973954-2.patch, failed testing. View results

dhirendra.mishra’s picture

dhirendra.mishra CreditAttribution: dhirendra.mishra commented
Status: Needs work » Needs review
FileSize
removed_redudant_must-2973954-3.patch669 bytes

I am uploading patch. Please test and review it.

Status: Needs review » Needs work

The last submitted patch, 4: removed_redudant_must-2973954-3.patch, failed testing. View results

juampynr’s picture

juampynr CreditAttribution: juampynr at Lullabot commented
Status: Needs work » Needs review
FileSize
drupal-remove_must-2973954-6.patch637 bytes

My previous patch failed for an unrelated reason. Re-submitting.

Status: Needs review » Needs work

The last submitted patch, 6: drupal-remove_must-2973954-6.patch, failed testing. View results

juampynr’s picture

juampynr CreditAttribution: juampynr at Lullabot commented
Status: Needs work » Needs review

Changing to needs review manually. The failure is due to an error in Nightwatch.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs review » Reviewed & tested by the community

This looks good, thanks!

  • larowlan committed 5d0a729 on 8.6.x 
    Issue #2973954 by juampynr, dhirendra.mishra: Fix typo at MigrateField....

  • larowlan committed 46d8908 on 8.5.x 
    Issue #2973954 by juampynr, dhirendra.mishra: Fix typo at MigrateField....
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 5d0a729 and pushed to 8.6.x.

Cherry-picked as 46d8908 and pushed to 8.5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.