mobile_number module dependency in marketing_cloud_sms [#2973144]

The initial plan was to add a mobile_number field of type "Mobile Number" to the user entity when marketing_cloud_sms was installed. This was halted to use a plain text type, due to outstanding Javascript bugs in Mobile Number that made it unusable in the short term. It was then decided that this would be out of scope for this module and that that responsibility should be up to modules that use marketing_cloud_sms as a dependency.

The mobile_number module is still listed as a dependency and needs to be removed from marketing_cloud_sms.info.yml. See test report: https://www.drupal.org/pift-ci-job/965180.

Comment	File	Size	Author
#7	marketing_cloud-remove_mobile_number_dependency-2973144-7.patch	412 bytes	john_a
#7

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 May 2018 at 21:01

john_a created an issue. See original summary.

Comment #2

john_a CreditAttribution: john_a as a volunteer commented 15 May 2018 at 21:01

Title:

mobilr_number module dependency in marketing_cloud_sms

» mobile_number module dependency in marketing_cloud_sms

Comment #3

john_a CreditAttribution: john_a as a volunteer commented 15 May 2018 at 21:03

Issue summary:

View changes

Comment #4

john_a CreditAttribution: john_a as a volunteer commented 15 May 2018 at 23:34

Status:

Active

» Needs review

This needs reviewing, so that I can close this ticket. @Bhanu, can you do this please? The main tests are running pareview, the unit tests (if you need help setting up phpunit tests on your local, let me know), and attempting a dummy end-to-end API call. See marketing_cloud_example for help on how to do this. The API call does not need to be 100% successful, but prove that the call does not fail due to unmet dependencies.