Latest Pareview report shows some doc formatting issues in MarketingCloudDataEventsTest.

See the attached file.

CommentFileSizeAuthor
#8 marketing_cloud-marketingclouddataeventstest-pareview-2972908-8.patch10.37 KBjohn_a
#7 marketing_cloud-marketingclouddataeventstest-pareview-2972908-7.patch10.15 KBjohn_a
MarketingCloudDataEventsTest-pareview.txt6.37 KBjohn_a
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

john_a created an issue. See original summary.

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Component: Documentation » Code
john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Assigned: Unassigned » john_a

  • john_a committed 75eba7a on 2972908-marketingclouddataeventstest-pareview 
    Issue #2972908: pareview issues fix

  • john_a committed eaa3524 on 2972908-marketingclouddataeventstest-pareview 
    Issue #2972908: pareview namespace test

  • john_a committed 8d63912 on 2972908-marketingclouddataeventstest-pareview 
    Issue #2972908: revert pareview namespace test
john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Assigned: john_a » Unassigned
Status: Active » Needs review
FileSize
marketing_cloud-marketingclouddataeventstest-pareview-2972908-7.patch10.15 KB

Patch prepared, please review.

I'm ignoring:

--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  47 | ERROR | [x] Namespaced classes/interfaces/traits should be
     |       |     referenced with use statements
 177 | ERROR | [x] Namespaced classes/interfaces/traits should be
     |       |     referenced with use statements

This makes no sense to me... there is a use statement!

See https://pareview.sh/pareview/https-git.drupal.org-project-marketing_cloud.git-2972908-marketingclouddataeventstest

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
FileSize
marketing_cloud-marketingclouddataeventstest-pareview-2972908-8.patch10.37 KB

Found a way to resolve the above issues:
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
47 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
177 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements

new patch

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Needs review » Fixed

Reviewed and patched by self

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Fixed » Closed (fixed)