Latest Pareview report shows some doc formatting issues in PushService.

See the attached file.

CommentFileSizeAuthor
#6 marketing_cloud-PushService_pareview-2972876-6.patch21.55 KBjohn_a
#4 marketing_cloud-pushservice-pareview-2972876-4.patch20.96 KBjohn_a
PushService-pareview.txt14.32 KBjohn_a
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

john_a created an issue. See original summary.

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Component: Documentation » Code
john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Assigned: Unassigned » john_a
john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Assigned: john_a » Unassigned
Status: Active » Needs review
FileSize
marketing_cloud-pushservice-pareview-2972876-4.patch20.96 KB

Please review this. Fixed up all pareview phpdoc issues. also found an issue with updatePushMessage() whichwas a copy n paste issue, duplicating functionality from deletePushMessage().

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Needs review » Needs work

There is not an issue updatePushMessage(), but that should be in a separate ticket.

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Needs work » Needs review
FileSize
marketing_cloud-PushService_pareview-2972876-6.patch21.55 KB

Patch recreated, please review.

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Needs review » Fixed

Patch reviewed and applied by self

john_a’s picture

john_a CreditAttribution: john_a as a volunteer commented
Status: Fixed » Closed (fixed)