I found a some things that were not renamed or moved as part of [#]

commerce_migate/src/Plugin/migrate/process/d7/CommerceReferenceRevision.php - this should not be in a d7 directory and it is only used in the commerce submodule so it should be moved there too.

./modules/commerce/src/Plugin/migrate/source/d7/ShippingFlatRate.php - this should not be in a d7 directory, instead it should be commerce1.

CommentFileSizeAuthor
#4 interdiff.txt4.98 KBquietone
#4 2971888-4.patch8.66 KBquietone
#3 interdiff.txt551 bytesquietone
#3 2971888-3.patch2.2 KBquietone
renames-missed.patch2.29 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, renames-missed.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs work » Needs review
FileSize
2971888-3.patch2.2 KB
interdiff.txt551 bytes

I shouldn't make a patch just before I have to leave for an appointment.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
FileSize
2971888-4.patch8.66 KB
interdiff.txt4.98 KB

This is bad. I found some more. I wish I knew how I missed these as aside from all the greps I looked at every plugin.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • heddn committed 692e6bd on 8.x-2.x authored by quietone 
    Issue #2971888 by quietone, heddn: Cleanup renaming that was missed
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.