Problem/Motivation

testQuickStartCommand failing on PHP5 because the commands under test are slow.

Proposed resolution

Let's have a look at the test output:

$ php core/scripts/drupal quick-start
Drupal is already installed. If you want to reinstall, remove sites/default/files and sites/default/settings.php.
Drupal development server started: <http://127.0.0.1:8888>
This server is not meant for production use.
One time login url: <http://127.0.0.1:8888/user/reset/1/1525511940/QdxTEwE8iXvj0TvzVm5GkYwWOUvSDA1QXEw_28clYzA/login>
Press Ctrl-C to quit.

As you see, we do start the development server first and then generate a one time login url, which happens afterwards. With this patch, we do have enough time between those steps.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2969738-2.patch958 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
2969738-2.patch958 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I've updated the issue summary to explain what is going on.

I think this is a significant fix, even the most ideal fix would probably involved having another while loop, just like the match for the hostname itself.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 1eb7fc0 and pushed to 8.6.x. Thanks!

  • alexpott committed 1eb7fc0 on 8.6.x 
    Issue #2969738 by alexpott: testQuickStartCommand failing on PHP5
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

#2966607: Invalidating 'node_list' and other broad cache tags early in a transaction severely increases lock wait time and probability of deadlock is suddenly failing — could that be caused by this?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.